[Patch] [regression] libvgl and r197330 (kbd)
Ben Kaduk
minimarmot at gmail.com
Sat Jun 18 00:49:28 UTC 2011
On Fri, Sep 25, 2009 at 8:39 AM, Ed Schouten <ed at 80386.nl> wrote:
> Hi all,
>
> * Kostik Belousov <kostikbel at gmail.com> wrote:
>> > Ah, it seems SDL also calls GIO_KEYMAP. Just rebuilding SDL should fix
>> > this. I promised to add a message to UPDATING as well, so I'll also
>> > mention SDL should be rebuilt as well.
>>
>> I consider this as a very strong argument to keep the existing ioctl
>> as is, and provide new ioctl that takes new table.
>
> I've attached a patch that should restore binary compatibility. I first
> thought this wasn't really needed, because most applications would use
> K_RAW instead of K_XLATE anyway.
>
> Just breaking binary compatibility with kbdcontrol(1) wouldn't have been
> too bad, but it turns out things like SDL use this as well. I've
> attached a patch that should restore binary compatibility. Anyone
> interested in testing this before I commit it to SVN?
Replying to ancient history, it looks like this patch never got
committed? The Debian kFreeBSD folks have run into a similar issue:
http://lists.debian.org/debian-bsd/2011/06/msg00238.html
proposing
===============
Upstream could do it properly, without ABI breaking, i.e. by
#define GIO_KEYMAP_OLD _IOR('k', 6, keymap_t)
#define PIO_KEYMAP_OLD _IOW('k', 7, keymap_t)
...
#define GIO_KEYMAP _IO('k', 16)
#define PIO_KEYMAP _IO('k', 17)
===============
Something to keep the ABI between 8 and 9 is probably still useful,
even at this juncture.
-Ben Kaduk
More information about the freebsd-current
mailing list