Multiple hpet messages during boot

M. Warner Losh imp at bsdimp.com
Fri Sep 17 15:39:21 UTC 2010


In message: <20100917055953.GF1036 at pluto.vnode.local>
            Joel Dahl <joel at FreeBSD.ORG> writes:
: On 16-09-2010  8:28, John Baldwin wrote:
: > On Wednesday, September 15, 2010 2:32:33 am Joel Dahl wrote:
: > > I noticed this during boot (HEAD from yesterday):
: > > 
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > 
: > > Is it really necessary to print this 8 times?
: > 
: > I'd actually like to remove the interrupt messages that say '[FILTER]' or 
: > '[GIANT]', etc.  I think in general they only add clutter.
: 
: Definitely agreed.  Go for it.

so is there support for the following:

Index: subr_bus.c
===================================================================
--- subr_bus.c	(revision 212791)
+++ subr_bus.c	(working copy)
@@ -3996,9 +3996,11 @@
 	    arg, cookiep);
 	if (error != 0)
 		return (error);
+	if (bootverbose == 0)
+		return (0);
 	if (handler != NULL && !(flags & INTR_MPSAFE))
 		device_printf(dev, "[GIANT-LOCKED]\n");
-	if (bootverbose && (flags & INTR_MPSAFE))
+	if (flags & INTR_MPSAFE)
 		device_printf(dev, "[MPSAFE]\n");
 	if (filter != NULL) {
 		if (handler == NULL)


Warner


More information about the freebsd-current mailing list