HEADSUP: zlib updated [svn commit: r205471 - in head: . lib/libz lib/libz/contrib lib/libz/doc sys/sys]

[Xin LI]

On Thu, Apr 1, 2010 at 12:59 PM, Tom Uffner <tom at uffner.com> wrote:
> Xin LI wrote:
>>
>> On Wed, Mar 31, 2010 at 6:56 PM, Tom Uffner<tom at uffner.com>  wrote:
>>>
>>> Michael Butler wrote:
>>>
>>>> This breaks most (if not all) of the QT4-dependent ports for the lack of
>>>> a definition of "off64_t".
>>>
>>> it also breaks multimedia/mplayer, graphics/ImageMagick, and
>>> print/ghostscript8 & everything that depends on it.
>>
>> Just because they used to compile DOES NOT mean they were right.  It's
>> NOT right to define _LARGEFILE64_SOURCE on FreeBSD, see:
>>
>> http://www.delorie.com/gnu/docs/glibc/libc_13.html
>
> i realize this. i was just adding to the list of ports that no longer
> build after this change. ghostscript is kind of important for print
> support.
>
> i doubt this is "right" either, but it is a quick & dirty way to
> make mplayer compile again:
>
> --- configure.orig      2010-04-01 15:49:37.000000000 -0400
> +++ configure   2010-04-01 15:50:50.000000000 -0400
> @@ -5337,7 +5337,7 @@
>  #include <dvdread/nav_read.h>
>  int main(void) { return 0; }
>  EOF
> -    cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> -D_LARGEFILE64_SOURCE \
> +    cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 \
>       -ldvdread $_ld_dl && _dvdread=yes && _res_comment="external"
>   fi
>  fi
> @@ -7412,8 +7412,6 @@
>  if test "$_largefiles" = yes || freebsd ; then
>   CFLAGS="$CFLAGS -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64"
>   if test "$_dvdread" = yes || test "$_libdvdcss_internal" = yes ; then
> -    # dvdread support requires this (for off64_t)
> -    CFLAGS="$CFLAGS -D_LARGEFILE64_SOURCE"
>     cygwin && CFLAGS="$CFLAGS -DSYS_CYGWIN"
>   fi
>  fi

I think the latest (1.2.4.1) zlib has a bug that prevents using
-D_LARGEFILE64_SOURCE at all, and expects -D_LARGEFILE64_SOURCE=1.
I'll submit a patch to upstream :(

Cheers,
-- 
Xin LI <delphij at delphij.net> http://www.delphij.net