8.0-BETA2: mi_startup() panic on VIA C7 diskless

John Baldwin jhb at freebsd.org
Wed Aug 12 13:32:20 UTC 2009


On Tuesday 11 August 2009 6:21:28 pm Julian Elischer wrote:
> Ed Schouten wrote:
> > * Kip Macy <kmacy at freebsd.org> wrote:
> >> http://people.freebsd.org/~kmacy/flowtable_boot.patch
> > 
> > +	if ((V_flowtable_enable == 0) || (V_flowtable_ready == 0)
> > 
> > should probably read:
> > 
> > +	if (V_flowtable_enable == 0 || V_flowtable_ready == 0)
> > 
> > Right?
> > 
> 
> 
> I prefer the first, with an extra closing paren.

style(9) prefers the latter assuming that it isn't confusing to read the 
latter (I do not think it is).

-- 
John Baldwin


More information about the freebsd-current mailing list