[patch] zfs livelock and thread priorities
Ben Kelly
ben at wanderview.com
Wed Apr 29 18:40:08 UTC 2009
On Apr 29, 2009, at 7:58 AM, Ben Kelly wrote:
> On Apr 29, 2009, at 2:43 AM, Jaakko Heinonen wrote:
>> On 2009-04-28, Ben Kelly wrote:
>>>> http://www.wanderview.com/svn/public/misc/zfs/zfs_zinactive_deadlock.diff
>>>
>>> The patch is updated in the same location above.
>>
>> There's a fatal typo in the patch:
>>
>> - ZFS_OBJ_HOLD_ENTER(zfsvfs, z_id);
>> + locked == ZFS_OBJ_HOLD_TRYENTER(zfsvfs, z_id);
>> ^^^^
>
> Yikes! Thanks for catching this!
>
> The patch has been updated at the same URL. If anyone has patched
> their system please grab the new version. Sorry for the confusion.
Argh! The patch was still broken even after this fix.
Apparently when I tested my taskqueue solution I forgot to do a make
installkernel. For some reason the taskqueue approach deadlocks my
server at home under normal conditions. Therefore I have reverted the
patch to use the simple return. I still don't think this is the right
solution, but I don't have time to completely figure out what is going
on right now.
Again, sorry for the mess!
- Ben
More information about the freebsd-current
mailing list