[PATCH] #endif comment fixes
Scot Hetzel
swhetzel at gmail.com
Sat Nov 15 11:11:02 PST 2008
On 11/15/08, Pankov Pavel <pankov_p at mail.ru> wrote:
> Hello.
>
> According to style(9), there can be a comment added to #endif, telling
> the reader about the corresponding #if* condition. This information
> isn't used by any program; it's just to save some time for humans,
> reading the code. And, as it isn't checked, these comments have
> accumulated many errors. Mainly, it's typos, copy-paste bugs, and file
> rename leftovers. I have prepared a patch to fix some of them in the
> tree. I clearly understand that the patch cannot be committed as is,
> because of touched files are maintained outside of FreeBSD source tree.
> But maybe respective maintainers will be able to review my patch and
> commit or submit fixes upstream. CVS diff against -CURRENT is available
> from
> http://files.pankov.pp.ru/freebsd/endif-comments-fix.diff.bz2
> (~ 14
The change to mcore.h is wrong, while it makes the #endif comment
match the #ifdef and #define at the top of the file, the #ifdef and
#define are misspelled:
-- contrib/binutils/include/elf/mcore.h 26 Jun 2001 16:57:18 -0000 1.1.1.3
+++ contrib/binutils/include/elf/mcore.h 15 Nov 2008 15:32:30 -0000
@@ -43,4 +43,4 @@
/* Section Attributes. */
#define SHF_MCORE_NOREAD 0x80000000
-#endif /* _ELF_MCORE_H */
+#endif /* _ELF_MORE_H */
Scot
More information about the freebsd-current
mailing list