need conf/kern.post.mk review

[Andrzej Tobola]

On Mon, Dec 15, 2008 at 10:07:20PM +0000, Bjoern A. Zeeb wrote:
> I lately tried to install a kernel as user to get a boot dir seeded. I
> found I can set KMODOWN and KMODGRP for installing modules but not the
> kernel.  Is there a reason for this or does this patch look ok?
> 
> http://people.freebsd.org/~bz/20081215-02-conf-kern.port.mk-ugio.diff

+1

If we are already on kern.port.mk what about the following patch
which gives the posibility to instal to fs  without chflags (e.g. nfs) ?
I am using it from a long time as can be seen from time-stamps.

--- /usr/src/sys/conf/kern.post.mk-OLD	2007-03-24 06:35:08.000000000 +0100
+++ /usr/src/sys/conf/kern.post.mk	2007-11-24 23:52:03.000000000 +0100
@@ -14,6 +14,12 @@
 .endif
 MKMODULESENV+=	KERNBUILDDIR="${.CURDIR}"
 
+.if defined(NO_FSCHG)
+CHFLAGS=	echo
+.else
+CHFLAGS=	chflags -R noschg
+.endif
+
 .MAIN: all
 
 .for target in all clean cleandepend cleandir clobber depend install \
@@ -208,11 +214,11 @@
 .if exists(${DESTDIR}${KODIR})
 	-thiskernel=`sysctl -n kern.bootfile` ; \
 	if [ ! "`dirname "$$thiskernel"`" -ef ${DESTDIR}${KODIR} ] ; then \
-		chflags -R noschg ${DESTDIR}${KODIR} ; \
+		${CHFLAGS} ${DESTDIR}${KODIR} ; \
 		rm -rf ${DESTDIR}${KODIR} ; \
 	else \
 		if [ -d ${DESTDIR}${KODIR}.old ] ; then \
-			chflags -R noschg ${DESTDIR}${KODIR}.old ; \
+			${CHFLAGS} ${DESTDIR}${KODIR}.old ; \
 			rm -rf ${DESTDIR}${KODIR}.old ; \
 		fi ; \
 		mv ${DESTDIR}${KODIR} ${DESTDIR}${KODIR}.old ; \
@@ -231,7 +237,7 @@
 
 
 kernel-reinstall:
-	@-chflags -R noschg ${DESTDIR}${KODIR}
+	@-${CHFLAGS} ${DESTDIR}${KODIR}
 	${INSTALL} -p -m 555 -o root -g wheel ${KERNEL_KO} ${DESTDIR}${KODIR}
 .if defined(DEBUG) && !defined(INSTALL_NODEBUG)
 	${INSTALL} -p -m 555 -o root -g wheel ${KERNEL_KO}.symbols ${DESTDIR}${KODIR}


cheers,
-at