audio/vido sync issue with latest www/chromium and auido/sndio

[Carlos Jacobo Puga Medina]

> Enviar: domingo 28 de julio de 2019 a las 11:41
> De: "Joseph Mingrone" <jrm at FreeBSD.org>
> Para: "Tobias Kortkamp" <tobik at freebsd.org>
> CC: "Carlos Jacobo Puga Medina" <cjpm at gmx.es>, freebsd-chromium at freebsd.org, cpm at freebsd.org
> Asunto: Re: audio/vido sync issue with latest www/chromium and auido/sndio
>
> Tobias Kortkamp <tobik at freebsd.org> writes:
> 
> > On Sat, Jul 27, 2019 at 01:24:32PM +0200, Tobias Kortkamp wrote:
> >> On Fri, Jul 26, 2019 at 08:31:51PM +0200, Carlos Jacobo Puga Medina wrote:
> >> > > Enviar: viernes 26 de julio de 2019 a las 20:04
> >> > > De: "Joseph Mingrone" <jrm at FreeBSD.org>
> >> > > Para: cjpm at gmx.es
> >> > > CC: "Tobias Kortkamp" <tobik at freebsd.org>, freebsd-chromium at freebsd.org, cpm at freebsd.org
> >> > > Asunto: Re: audio/vido sync issue with latest www/chromium and auido/sndio
> 
> >> > > cjpm at gmx.es writes:
> 
> >> > > > El 26 de julio de 2019 15:36:17 CEST, Joseph Mingrone <jrm at FreeBSD.org> escribió:
> >> > > >>"Carlos Jacobo Puga Medina" <cjpm at gmx.es> writes:
> 
> >> > > >>>> Enviar: viernes 26 de julio de 2019 a las 6:10
> >> > > >>>> De: "Tobias Kortkamp" <tobik at freebsd.org>
> >> > > >>>> Para: "Joseph Mingrone" <jrm at ftfl.ca>
> >> > > >>>> CC: freebsd-chromium at freebsd.org, cpm at freebsd.org
> >> > > >>>> Asunto: Re: audio/vido sync issue with latest www/chromium and
> >> > > >>auido/sndio
> 
> >> > > >>>> On Thu, Jul 25, 2019 at 09:26:43AM -0300, Joseph Mingrone wrote:
> >> > > >>>> > Hello all,
> 
> >> > > >>>> > On two different 12.0-RELEASE-p6 systems, I recently noticed that
> >> > > >>the
> >> > > >>>> > audio on YouTube videos now becomes out of sync with the video. 
> >> > > >>The
> >> > > >>>> > chromium-75.0.3770.142 package was built with the CODECS, CUPS,
> >> > > >>DRIVER,
> >> > > >>>> > KERBEROS, and SNDIO knobs on.
> 
> >> > > >>>> The only recent sndio related change in Chromium has been ports
> >> > > >>>> r506266 which merged the new sndio input implementation from
> >> > > >>OpenBSD.
> >> > > >>>> Try reverting it and see if the problem is still there.
> 
> 
> >> > > >>> If the issue is related to the last change introduced, we should
> >> > > >>report it to OpenBSD, right?
> 
> >> > > >>> If it has already been reported, everything will go faster.
> 
> >> > > >>> Best regards,
> >> > > >>> --
> >> > > >>> Carlos Jacobo Puga Medina <cjpm at gmx.es>
> 
> >> > > >>Hi,
> 
> >> > > >>I downgraded sndio to version 1.5.0 and the problem with www/chromium
> >> > > >>was still there.  Videos in www/firefox work fine with both versions of
> >> > > >>sndio.
> 
> 
> >> > > > Please revert r506266 and rebuild www/chromium
> 
> >> > > > https://svnweb.freebsd.org/ports?view=revision&revision=506266
> 
> >> > > The audio and video stay in synch after reverting r506266.
> 
> 
> >> > If the sndio port and these patches that implement the audio recording support are synchronized, we have overlooked some detail before committing changes.
> 
> >> > Please, Tobias can you confirm the issue?
> 
> >> It looks like this also happens on OpenBSD.  The OpenBSD Chromium
> >> maintainer is aware of the issue and will look into it soon.
> 
> > Joseph, can you give this patch a try?  It fixes the problem for
> > me.
> 
> > https://github.com/t6/freebsd-ports-sndio/commit/c0a5de2172af87339d1ee3de4a7a8f8b368a15c2.diff
> 

I've purposely reopened the PR238869. Can you submit the patch there?

> Hello Tobias,
> 
> I've only watched a few videos, but things looks good.  I will send an
> update if I encounter the problem later.
> 

Today I'll commit the proposed patch.

Thanks to both of you!