Chromium Build Failures

[Ori Bernstein]

So, I'm trying to build the most recent Chromium port in order to attempt
debugging some issues that I'm seeing, and I'm currently getting a few
build failures:

	[179/16428] python "/usr/home/ori/src/ports/freebsd-chromium/www/chromium/work/chromium-54.0.2840.100/build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="llvm-nm39"  --sofile="./libbase.so" --tocfile="./libbase.so.TOC" --output="./libbase.so" -- clang++39 -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -pthread -m64 -Wl,--export-dynamic -L/usr/local/lib -o "./libbase.so" -Wl,-soname="libbase.so" @"./libbase.so.rsp"
	FAILED: libbase.so libbase.so.TOC
	python "/usr/home/ori/src/ports/freebsd-chromium/www/chromium/work/chromium-54.0.2840.100/build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="llvm-nm39"  --sofile="./libbase.so" --tocfile="./libbase.so.TOC" --output="./libbase.so" -- clang++39 -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -pthread -m64 -Wl,--export-dynamic -L/usr/local/lib -o "./libbase.so" -Wl,-soname="libbase.so" @"./libbase.so.rsp"
	obj/base/base/launch_posix.o: In function `base::(anonymous namespace)::GetEnvironment()':
	../../base/process/launch_posix.cc:(.text+0x1fd7): undefined reference to `environ'
	obj/base/base/launch_posix.o: In function `base::(anonymous namespace)::SetEnvironment(char**)':
	../../base/process/launch_posix.cc:(.text+0x20e7): undefined reference to `environ'

Working around it for the sake of the build by removing the extern on environ
(even though I'm almost entirely certian that it won't work correctly in the
final version, I get the missing '-lexecinfo' that I initially ran into
in bug 214450:

	obj/third_party/WebKit/Source/wtf/wtf/Assertions.o: In function `WTFGetBacktrace(void**, int*)':
	./out/Debug/../../third_party/WebKit/Source/wtf/Assertions.cpp:167: undefined reference to `backtrace'
	clang-3.9: error: linker command failed with exit code 1 (use -v to see invocation)

I'm runnign on 

	$ uname -a
	FreeBSD oneeye 11.0-RELEASE-p1 FreeBSD 11.0-RELEASE-p1 #0 r306420: Thu Sep 29 01:43:23 UTC 2016     root at releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

Is there anything obvious I'm missing? For the environ, it seems like we may
be running into the same issue as this:

	https://git.merproject.org/mer-core/qtbase/commit/ccf74b592809e0c5a613eff27d6431a4c659e368

Buy I don't see anything in either linker flags or the wrapper scripts that
would lead to -Wl,-no-undefined getting passed down here. Does lld behave
differently than gnu ld? I noticed that we seem to be using it now, no idea
how new that is.

I've definitely built older versions successfully.

-- 
    Ori Bernstein