[package - head-amd64-default][www/chromium] Failed for chromium-54.0.2840.100_1 in build

[clutton]

On Sat, 2016-12-10 at 14:03 -0800, Cy Schubert wrote:
> The hackish patch to address this and a subsequent break is:
> 
> Index: /usr/ports/www/chromium/Makefile
> ===================================================================
> --- /usr/ports/www/chromium/Makefile    (revision 428271)
> +++ /usr/ports/www/chromium/Makefile    (working copy)
> @@ -16,6 +16,10 @@
>  
>  BROKEN_FreeBSD_9=does not configure
>  
> +CC=            /usr/local/bin/clang38
> +CXX=           /usr/local/bin/clang++38 
> +CPP=           /usr/local/bin/clang-cpp38
> +
>  BUILD_DEPENDS= ${LOCALBASE}/bin/gperf:devel/gperf \
>                 bash:shells/bash \
>                 python:lang/python \
> Index: /usr/ports/www/chromium/files/patch-services_ui_ws_BUILD.gn
> ===================================================================
> --- /usr/ports/www/chromium/files/patch-
> services_ui_ws_BUILD.gn (revision 
> 428271)
> +++ /usr/ports/www/chromium/files/patch-services_ui_ws_BUILD.gn 
> (nonexistent)
> @@ -1,14 +0,0 @@
> ---- services/ui/ws/BUILD.gn.orig       2016-10-06 04:02:24.000000000
> +0300
> -+++ services/ui/ws/BUILD.gn    2016-10-19 11:13:25.102806000 +0300
> -@@ -103,6 +103,11 @@
> -     "window_tree_host_factory.h",
> -   ]
> - 
> -+  # Work around base r261801
> -+  if (is_bsd) {
> -+    defines = ["_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1"]
> -+  }
> -+
> -   deps = [
> -     # TODO(sad): Temporary, until the GPU process is split out of
> ws.
> -     "//services/ui/gpu",

I hardcoded CC, CXX. This was done intentionally, chromium build system
assume that you don't take things from environment. May be better way
to do something with REPLACE_CMD in Makefile...??? Feel free to hack.

Also with recent CURRENT updates, we don't need that define, although
we need it for other supported bsd's < CURRENT. Can you look how we
applied the patch for < FreeBSD 10 and do this one in similar manner?
May be using devel/libc++ for everything < CURRENT and removing this
patch for all BSD's?

Then and only then, post merge request to github, or create a bug in
usual way.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freebsd.org/pipermail/freebsd-chromium/attachments/20161212/79f27cab/attachment.sig>