[chromium-packagers] more thoughts on porting Chromium to FreeBSD

[René Ladan]

On 03/10/2014 18:22, Lei Zhang wrote:
> On Mon, Mar 10, 2014 at 9:59 AM, Torne (Richard Coles)
> <torne at chromium.org> wrote:
>> On 10 March 2014 16:13, René Ladan <rene at freebsd.org> wrote:
>>> Hm, there does not seem to be a hard rule here. Somehow having dedicated
>>> _freebsd files looks cleaner but that does impose more work.
>>
>> It might look cleaner but if there are cases where the code in _freebsd
>> would be basically the same, or literally identical, then this makes
>> maintaining the codebase much harder. Duplication is bad :)
> There is no hard rule. Use your best judgement on this. If the FreeBSD
> implementation is completely different, or if trying to share code
> with other POSIX implementations lead to #ifdef hell, then it might
> make sense to break out the code into a _freebsd file.
Yes, that would make the most sense I think.
> In base/ there is a base/nix directory that's POSIX but not Mac.
> However, the convention has no spread to other parts of the source
> code.
No, only files related to xdg there.
> Also, you may want to have this discussion on chromium-dev with a
> wider audience, rather than chromium-packagers.
>
Heh, I suggested that in the private mail but then ti was suggested to
send it to chromium-packagers instead.

René