chromium clang build broken

[George Liaskos]

On Sat, Jul 14, 2012 at 1:52 AM, David Thiel <lx at freebsd.org> wrote:
> Hi team,
>
> Currently the build is broken with clang, with the following types of error:
>
> CXX(host) out/Release/obj.host/protobuf_full_do_not_use/third_party/protobuf/src/google/protobuf/stubs/structurally_valid.o
>   CXX(host) out/Release/obj.host/protobuf_full_do_not_use/third_party/protobuf/src/google/protobuf/descriptor.o
> error: error: error: error: unable unableto  loadto unable  loadplugin toplugin
>        load
> '/usr/ports/www/chromium/work/chromium-courgette-redacted-20.0.1132.57/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so': plugin      unable'/usr/ports/www/chromium/work/chromium-courgette-redacted-20.0.1132.57/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so':
>
>
> The solution is to patch build/common.gypi to have clang_use_chrome_plugins set
> to 0. This should have no side effects, as it's intended for use during code
> development.
>
> I can commit this myself if you like, whatever works.
>
> Thanks,
> David

No need to patch common.gypi, just set the variable in gyp_defines.
http://www.freebsd.org/cgi/query-pr.cgi?pr=169816

Someone should commit this and close the PR, rene@ is off for holidays.