[PATCH] clean process task management :)

Baptiste Daroussin bapt at freebsd.org
Sun Feb 6 23:59:06 UTC 2011


Hi,

with the following patches chromium should be /proc free or very close to.
I replaced the base/process_util_linux.cc by a
base/process_util_freebsd.cc which have some code copied/inspired from
process_util_mac.mm and some code from me (most of it :))

I also comes with a fix : moving GetNumberOfProcessor() from
sys_info_proc to sys_info_freebsd as it is done for openbsd.

in process_util_freebsd is only miss the EnableTerminasonOnOutOfMemory
(because I can't understand anything on that :)) so I disabled it from
chrome/app/chome_exe_main_gtk.cc (should be fixed, but I don't know
how :) any volunteer ?)

from my point of view the taskmanager work, I wan't test about:memory
as I am still not able to render a page.

May be there are some mistakes in unit (kByte instead of Byte or
things like that I can't check)

the way we list processes (the same that is done on mac) is way
cleaner than the linux one, and should perform better.

You can find the patches here: http://people.freebsd.org/~bapt/chrome-noproc/
some are new some just replace the exiting one.

after that you need to edit base/base.gpyi to exclue
process_util_linux.cc on freebsd and append process_util_freebsd.cc to
the long list of cc files (sorry I haven't made a patch for that.

Now time to sleep :)

regards,
Bapt


More information about the freebsd-chromium mailing list