[Bug 245476] config(8) line parsing fragile

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Thu Apr 9 14:19:57 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245476

            Bug ID: 245476
           Summary: config(8) line parsing fragile
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: bugs at FreeBSD.org
          Reporter: kevans at freebsd.org

get_word and get_quoted_word, at the very least, are currently quite fragile --
they're expecting short subjects, which won't necessarily be the case. This can
be easily seen by reverting the parts of r359689 that doubled the line buffer
sizes and observing the new output to stderr as it tries to parse too long of
lines. Previously, we just clobbered memory past the line buffer and did the
wrong thing.

r359689 was just a band-aid, though -- these sizes will need adjusted as needs
change and randomly blow up on valid config bits. It would be nicer/more
developer friendly to be more dynamic here.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list