kern/185909: ALTQ activation problem

[Aurelien Rougemont]

>Number:         185909
>Category:       kern
>Synopsis:       ALTQ activation problem
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 20 13:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Aurelien Rougemont
>Release:        freebsd10 svn://svn0.eu.freebsd.org/base/stable/10  r260830
>Organization:
>Environment:
FreeBSD syklone2.colorz.lan 10.0-PRERELEASE FreeBSD 10.0-PRERELEASE #1 r260504: Fri Jan 10 12:45:34 UTC 2014     root at syklone2.colorz.lan:/usr/obj/usr/src/sys/COLORZ  amd64

>Description:
I am trying to build a kernel and its klm with ALTQ support.

I did build an amd64 kernel with the good options (cf how to repeat the problem for the exact configuration). The kernel is booting up but pfctl -f /etc/pf.conf reports : 

  # pfctl -f /etc/pf.conf
  pfctl: igb0: driver does not support altq


I dug a bit in the driver code and found this written in the /usr/src/sys/modules/igb/Makefile :

  # IGB_LEGACY_TX will override the stack if_transmit path and
  # instead use the older if_start non-multiqueue capable interface.
  # This might be desireable for testing, or to enable the use of
  # ALTQ. 
  #CFLAGS  += -DIGB_LEGACY_TX

I Did try to build the kernel with this CFLAG (at the make.conf level, then modifiying the Makefile just in case).

The build failed with this :


>How-To-Repeat:
Create a kernelconfig like this :

  include GENERIC
  ident COLORZ
  
  options         ALTQ
  options         ALTQ_CBQ        # Class Based Queuing (CBQ)
  options         ALTQ_RED        # Random Early Detection (RED)
  options         ALTQ_RIO        # RED In/Out
  options         ALTQ_HFSC       # Hierarchical Packet Scheduler (HFSC)
  options         ALTQ_PRIQ       # Priority Queuing (PRIQ)
  options         ALTQ_NOPCC      # Required for SMP build

and buildkernel gives :

  # make -s -j5 buildkernel

  [...]
  /usr/src/sys/modules/igb/../../dev/e1000/if_igb.c:2383:19: error: unused variable 'txr' [-Werror,-Wunused-variable]
          struct tx_ring          *txr = adapter->tx_rings;
                                 ^
  1 error generated.
>Fix:
N/A

>Release-Note:
>Audit-Trail:
>Unformatted: