bin/156817: WITHOUT_CDDL and NO_CTF ignored if WITH_CTF defined

[David O'Brien]

>Number:         156817
>Category:       bin
>Synopsis:       WITHOUT_CDDL and NO_CTF ignored if WITH_CTF defined
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 04 15:30:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     David O'Brien
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD dragon.NUXI.org 9.0-CURRENT FreeBSD 9.0-CURRENT #664 r221012M: Mon Apr 25 08:32:28 PDT 2011 root at dragon.NUXI.org:/sys/i386/compile/DRAGON i386
>Description:
	Starting with r206082 (I believe), the "-DNO_CTF" became ignored
	in the "stage 1.1: legacy release compatibility shims",
	"stage 1.2: bootstrap tools", "stage 2.3: build tools", and
	"stage 3: cross tools" parts of the build if
	WITH_CTF=yes is in '/etc/src.conf'.
	John Birrell's claim in r179233 is that these stages of the build
	do not require CTF conversion.

	Additionally, it appears that WITH_CTF now has higher precidence
	than WITHOUT_CDDL.  [WITH_CTF=yes in /etc/src.conf combined with
	'make -DWITHOUT_CDDL buildworld' or WITHOUT_CDDL=yes in /etc/make.conf]
	If so, I feel this is wrong as if someone has set WITHOUT_CDDL
	they have strong licensing needs (restrictions).  And so not
	running the CTF tools is of lesser importance than accidently
	falling into a legal problem.
>How-To-Repeat:
	Perform builds with the above settings and look at the output
>Fix:
	revisit r206082.

>Release-Note:
>Audit-Trail:
>Unformatted: