bluetooth.h, c++ include error
Maksim Yevmenkin
maksim.yevmenkin at gmail.com
Mon Oct 26 17:43:36 UTC 2009
On Tue, Oct 6, 2009 at 8:48 AM, Masoom Shaikh <masoom.shaikh at gmail.com> wrote:
>
>
> On Mon, Oct 5, 2009 at 5:26 PM, Iain Hibbert <plunky at rya-online.net> wrote:
>>
>> On Mon, 5 Oct 2009, Masoom Shaikh wrote:
>>
>> > what i am requesting is just variable name change ;-) my tree is at
>> > revision 197571, thus the patch i am presenting is also generated
>> > against it reject this if you want patch against latest revision
>> >
>> > renamed second argument of bt_devfilter() from 'new' to 'dfnew'. df for
>> > device filter to maintain uniformity renamed third argument from 'old'
>> > to 'dfold'.
>>
>> style(9) mentions that for kernel include files exposed to userland
>> (technically, this is always in userland but perhaps the same rules apply)
>> the prototype tag arguments should be made safe, eg starting with a _
>> perhaps for much this reason..
>>
>> so, my suggestion would be to use _new and _old etc..
>>
>> iain
>>
>> (or, just don't use them, they are not especially required :)
>>
> so this shall work
> i just renamed bt_devfilter() variable names, because it was the one which
> caused trouble
> will someone commit this ?
i just committed fix for this.
thanks
max
More information about the freebsd-bluetooth
mailing list