config files

[Maksim Yevmenkin]

Iain,

>>>Its just that to add a mouse to the system, I needed to enter details in 3
>>>files (and, details are held in two more) which could be considered a bit
>>>much just for a mouse :)
>>
>>3 files, i assume, are: /etc/bluetooth/hosts, /etc/bluetooth/hcsecd.conf and
>>/etc/bluetooth/bthidd.conf. entry in /etc/bluetooth/hosts file is optional.
>>
>>i'm not sure which other 2 files you are talking about.
> 
> /var/db/bthcid.keys & /var/db/bthidd.hids
> 
> which are automatic, though may need attention when batteries are changed?

yes, they these are "configuration files", but they are not really 
"configuration files" :) these are "persistent store". the only purpose 
of these is to preserve state between restarts.

i doubt that these will need any attention when battery changed, because 
the remote device (i.e. mouse, keyboard etc.) has its own "persistent 
store" where all link keys and other settings are kept.

it should almost never be required to modify /var/db/bthcid.keys file.

/var/db/bthidd.hids may need some attention (depending on the remote 
device), but bthidcontrol(8) "forget" command can be used for this.

>>>vaguely related to this, would the attached patch work to reload
>>>bthidd.conf on SIGHUP? It seems that it should, though I'm not sure if the
>>>fact that the new_device field is set would be an issue (maybe not, if the
>>>session already exists?)
>>
>>there is one problem with this particular patch. please see my comments inline
> 
> Ok, this should be better - seems to work for me, thanks!
> 
> (also you may need to enable "reload" in /etc/rc.d/bthidd?)
> 
> --
> 
> On another issue, in libsdp/session.c you have
> 
> 	sa.l2cap_psm = htole16(NG_L2CAP_PSM_SDP);
> 
> which seems wrong? (will work ok on little endian machine)

actually, no. i think the problem is with bthidd(8) (and others, i.e. 
sdpd(8)). bluetooth byte order is le16. so, l2cap_psm field in 
sockaddr_l2cap should always be in le16 byte order.

thanks for catching this!

[...]

>  
> +	sas.sa_handler = sighup;

this is obviously a typo. it should be "sa.sa_handler = sighup;". 
otherwise it wont compile. did you sent the patch before you have 
actually tried it?

thanks,
max