bin/56502

Brian F. Feldman green at freebsd.org
Mon Oct 6 17:24:35 PDT 2003


I don't see any errors; there is a part that seems unnecessary, and a couple 
places that have/don't have spaces where they would be preferred (so these 
are just style issues anyway, not very important):
    -           state[-1] = MAX_TYPES * (rptr - state) + rand_type;
    +           state[-1] = MAX_TYPES * (uint32_t)(rptr - state) + rand_type;
I believe that you don't need to cast in that situation, that you will get a 
compatible size_t or something close to that.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\




More information about the freebsd-audit mailing list