review for newbus usage needed

Bernd Walter ticso at cicely12.cicely.de
Sun Aug 10 07:33:46 PDT 2003


Index: iicbus.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/iicbus/iicbus.c,v
retrieving revision 1.16
diff -u -r1.16 iicbus.c
--- iicbus.c    23 Mar 2002 15:47:17 -0000      1.16
+++ iicbus.c    10 Aug 2003 14:29:39 -0000
@@ -132,9 +132,7 @@
        printf("\n");
 #endif
   
-       /* attach any known device */
-       device_add_child(dev, NULL, -1);
-
+       bus_generic_probe(dev);
        bus_generic_attach(dev);
          
         return (0);
Exit 1

Without this change only iic attaches to iicbus.
With this change iic and iicsmd attaches as intended.

Is this the correct fix?

Is it correct bahavour that device_add_child(dev, NULL, -1); only
attaches a single match?

-- 
B.Walter                   BWCT                http://www.bwct.de
ticso at bwct.de                                  info at bwct.de



More information about the freebsd-audit mailing list