Driver for Raspberry Pi 4 PCI-express controller

[Klaus Küchemann]

Hi, 
thanks, Vincent, for your extensive testing, very helpful ! 
`hope it’s okay for you to keep this discussion public(forward to freebsd-arm at freebsd.org) .

> Am 30.05.2020 um 20:11 schrieb Vincent M. Jr <>:
> 
> dmesg: https://dmesgd.nycbug.org/index.cgi?do=view&id=5523
> 
> …….
> It isn't perfectly stable, but at least initially working…..

Yeah, initially (sometimes) works for me too...
> 
> Testing it with a USB-C (with adapter) ethernet + 3-port hub. I'm using this for wired ethernet rather than the built in ethernet just for testing.
> 
> On the three hub ports, I have a microsoft keyboard, microsoft mouse, and a kingston datatraveler thumbdriv
> There is also a Logitech keyboard on one of the Pi's USB 2.0 ports

Did you test hot-unplugging/replugging the peripherals ?

> 
> For testing, I've created a single-drive ZFS pool with the kingston drive.
> 
> I went to delete a test file, and got the following:
> 
> xhci_interrupt: host system error
> xhci0: Resetting controller
> uhub0: at usbus0, port 1, addr 1 (disconnected)
> ugen0.2: <vendor 0x2109 USB2.0 Hub> at usbus0 (disconnected)
> uhub1: at uhub0, port 1, addr 1 (disconnected)
> ugen0.3: <Generic 4-Port USB 2.0 Hub> at usbus0 (disconnected)
> uhub2: at uhub1, port 1, addr 2 (disconnected)
> ugen0.4: <Kingston DataTraveler 3.0> at usbus0 (disconnected)
> umass0: at uhub2, port 1, addr 3 (disconnected)
> (da0:umass-sim0:0:0:0): WRITE(10). CDB: 2a 00 00 a0 21 a5 00 00 80 00
> (da0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
> (da0:umass-sim0:0:0:0): Retrying command, 3 more tries remain
> 
> But every single device had to be re-detected which took ~5-10 seconds to complete.

Yeah, experienced that too ...

> 
> 
> On another boot attempt, I'm getting this repeatedly while at the login prompt:...usb_alloc_device: device init 2 failed (USB_ERR_TIMEOUT, ignored)...ugen0.2: <Unknown > at usbus0 (disconnected)….

This is a  very interesting information   :
<another boot attempt> … do you mean that not every boot-attempt does the same (for unknown reason)
(That’s what I have experienced but I wasn’t sure whether  my uSD is damaged or whether it`s caused by the pie-driver-electricity ??
Specially the <Unknown > at -thing only appears in some boot attempts(not all)
In my tests the strange thing is that one boot-attempt succeeds and another not , while left the machine completely untouched between those attempts..



> update: i've gotten this also while doing a lengthy transfer to USB ZFS pool, and the error cycling never stops.

 I will try to make a ZFS-pool-test...

> 
> xhci0: Controller reset timeout.
> uhub0 on usbus0
> uhub0: <0x1106 XHCI root HUB, class 9/0, rev 3.00/1.00, addr 1> on usbus0
> uhub0: 5 ports with 4 removable, self powered
> xhci0: Resetting controller
> usb_alloc_device: device init 2 failed (USB_ERR_TIMEOUT, ignored)
> ugen0.2: <Unknown > at usbus0 (disconnected)
> uhub_reattach_port: could not allocate new device
> uhub0: at usbus0, port 1, addr 1 (disconnected)
> uhub0: detached
> xhci0: Controller halt timeout.
> xhci0: Controller reset timeout.
> xhci0: Controller reset timeout.
> uhub0 on usbus0
> uhub0: <0x1106 XHCI root HUB, class 9/0, rev 3.00/1.00, addr 1> on usbus0
> uhub0: 5 ports with 4 removable, self powered
> xhci0: Resetting controller
> usb_alloc_device: device init 2 failed (USB_ERR_TIMEOUT, ignored)
> ugen0.2: <Unknown > at usbus0 (disconnected)
> uhub_reattach_port: could not allocate new device
> uhub0: at usbus0, port 1, addr 1 (disconnected)
> uhub0: detached
> xhci0: Controller halt timeout.
> xhci0: Controller reset timeout.
> xhci0: Controller reset timeout.
> 
> 
> ……..

 xhci0 is this : 
https://svnweb.freebsd.org/base/head/sys/dev/usb/controller/generic_xhci.c?view=markup
(and the corresponding fdt/acpi-files) 

uhub0 is this :
https://svnweb.freebsd.org/base/head/sys/dev/usb/usb_hub.c?view=markup

Thanks again for testing,
Regards