"ARM64TODO: fill_fpregs32" showed up while building armv7 ports via poudriere on aarch64 (head -r359427)

[Olivier Houchard]

Hi Mark,

On Tue, Apr 21, 2020 at 11:05:52PM -0700, Mark Millard via freebsd-arm wrote:
> This is a aarch64 head -r359427 based FreeBSD context.
> 
> While building armv7 ports via poudriere-devel on a OverDrive 1000
> (cortex-A57 aarch64 head -r359427 FreeBSD context) I got:
> 
> [00:24:07] [04] [00:00:00] Building x11/libICE | libICE-1.0.10,1
> ARM64TODO: fill_fpregs32[00:24:28] [03] [00:00:22] Finished devel/libltdl | libltdl-2.4.6: Success
> 
> (poudiere was running on the console.)
> 
> devel/gettext-tools and devel/swig30 were also building
> at the time.
> 
> man arch reports:
> 
> QUOTE
>      aarch64 will support execution of armv6 or armv7 binaries if the CPU
>      implements AArch32 execution state, however armv5 binaries aren't
>      supported.
> END QUOTE
> 
> (It is referencing chroot style, not lib32, despite not being
> explicit about the distinctions.)
> 
> Is the support of armv7 binaries not yet fully true?
> 
> Does the "ARM64TODO: fill_fpregs32" notice imply that
> there might be problems with what was built?
> 

This should mostly shows up when a process crashes, so I'd guess you
have a core dump somewhere. We should probably just get ride of the
printf(), fill_fpregs32() is mostly compatible with what the arm port
does, where fill_fpregs() just zeroes the registers.
AFAIK the support for armv7 binaries is pretty complete, that doesn't
mean there's no bug, though.

Regards,

Olivier