[Differential] [Accepted] D2340: Support for Alpine platform from Annapurna Labs

[ian (Ian Lepore)]

ian accepted this revision.
ian added a comment.

I'm putting in an 'accept' here but want to note that I haven't carefully reviewed the entire change, partly because of time and mostly because it's so PCI-related and I don't know much about PCI.  I do however want to record that my previous comments don't amount to blocking the changes.


INLINE COMMENTS
  sys/arm/annapurna/alpine/alpine_machdep_mp.c:106 Ah, I didn't realize these were not general-purpose systems oriented towards the end user.  For that case, compiling in the dtb and skipping loader(8) seems reasonable.
  sys/boot/fdt/dts/arm/annapurna-alpine.dts:2 I'm about 100% ignorant of linux versioning, release schedules, etc.  If it's difficult to import the files into our sys/gnu area right now because of where they're at in the linux universe, then I agree that we should try to make the files we put into our sys/boot area as close as we can to what we think the final linux/official files will look like.

REVISION DETAIL
  https://reviews.freebsd.org/D2340

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: jpa-semihalf.com, andrew, imp, ian
Cc: emaste, meloun-miracle-cz, onwahe-gmail-com, freebsd-arm