[Differential] [Accepted] D3094: Fix KSTACK_PAGES issue

Thu Jul 16 09:34:00 UTC 2015

kib accepted this revision.
kib added a reviewer: kib.
kib added a comment.
This revision has a positive review.

I am fine with the last patch, which adds missing include.

Note that it uncovers more serious issues.  E.g., the quick look at the amd64/amd64/stack_machdep.c clearly indicates that the use of KSTACK_PAGES there is bogus, probably curthread->td_kstack_pages is the right thing to use, but it is still not quite correct as well.  In fact, the if() should check whether the f_frame is inside the [curthread->td_kstack; curthread->td_kstack + PAGE_SIZE * curthread->td_kstack_pages).

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D3094

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: wma_semihalf.com, emaste, zbb, andrew, kib
Cc: kib, imp, andrew, freebsd-arm-list, emaste