[Differential] [Updated] D2378: Introduce ITS support for ARM64

Wed Jul 15 13:58:36 UTC 2015

zbb marked 3 inline comments as done.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3_fdt.c:199-200 FDT bindings. Removed comment in the commit.
  sys/arm64/arm64/gic_v3_fdt.c:280 There are two sets of probe/attach pairs here.
  sys/arm64/arm64/gic_v3_fdt.c:299 There are two sets of probe/attach pairs here. I think that this is not an unusual thing when we have attachments for two different drivers in the same file:

  /* Driver A */
  stuff_A;
  probe_A();
  attach_A();

  /* Driver B */
  stuff_B;
  probe_B();
  attach_B();

  They could be in a separate files but this is more convenient.
  sys/arm64/arm64/gic_v3_its.c:818 CPU writes to its cache while ITS has its own. We need this to stay coherent.
  sys/arm64/arm64/gic_v3_its.c:821 Everyone knows what barriers are for ...
  Is the necessity of detailed explanation of barriers usage limited only to ITS driver or other ARM64 code also has it? 
  sys/arm64/arm64/gic_v3_its.c:1077-1080 I will ask him.

REVISION DETAIL
  https://reviews.freebsd.org/D2378

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, imp, ian, emaste, manpages, andrew
Cc: eadler, gnn, kib, emaste, andrew, freebsd-arm-list, imp