arm/186129: ti mbox and pruss has params to mtx_init reversed

Takanori Sawada tak.swd at gmail.com
Sun Jan 26 14:10:00 UTC 2014


>Number:         186129
>Category:       arm
>Synopsis:       ti mbox and pruss has params to mtx_init reversed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-arm
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 26 14:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Takanori Sawada
>Release:        
>Organization:
>Environment:
FreeBSD Current
>Description:
Args are in wrong order to mtx_init(9)

(1)
http://svnweb.freebsd.org/base/head/sys/arm/ti/ti_mbox.c?revision=258209&view=markup#l143

now:
mtx_init(&sc->sc_mtx, "TI mbox", MTX_DEF, 0);

correct:
mtx_init(&sc->sc_mtx, "TI mbox", NULL, MTX_DEF);


(2)
http://svnweb.freebsd.org/base/head/sys/arm/ti/ti_pruss.c?revision=258210&view=markup#l169

now:
mtx_init(&sc->sc_mtx, "TI PRUSS", MTX_DEF, 0);

correct:
mtx_init(&sc->sc_mtx, "TI PRUSS", NULL, MTX_DEF);
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-arm mailing list