sdhci_fdt ignores clock-frequency property in .dtb

[Warner Losh]

http://svnweb.freebsd.org/base/vendor/device-tree/dist/Bindings/mmc/mmc.txt?revision=262573&view=markup

has the standard which we try to follow (but sometimes fall short) on. There’s several properties we currently ignore, but perhaps shouldn’t.

Warner


On Apr 30, 2014, at 8:46 AM, Thomas Skibo <ThomasSkibo at sbcglobal.net> wrote:

> 
> It looks like one other platform uses sdhci_fdt: exynos5250 (Chromebook).  See exynos5250.dtsi.  The "/* TODO: verify freq */" comment leads me to think they noticed that property wasn't working.
> 
> I'm okay with max-frequency.  I can generate a new patch.
> 
> On 4/29/14, 5:05 PM, Ian Lepore wrote:
>> On Tue, 2014-04-29 at 14:35 -0700, Thomas Skibo wrote:
>>> Another Zynq bug-fix.  One Zynq board out there needs to set this
>>> property or else the SD card gets clocked too fast.
>>> 
>>> Thanks,
>>> 
>> 
>> The documented property for this is max-frequency rather than
>> clock-frequency.  Is this a completely new property for us, or are you
>> just making the code honor what's in our existing dts files?  Either way
>> we should use the documented name, I'm just wondering if we need to fix
>> dts files and give folks a heads-up about the change.
>> 
>> -- Ian
>> 
>> 
>> 
> 
> -- 
> --------
> Thomas Skibo
> ThomasSkibo at sbcglobal.net
> 
> _______________________________________________
> freebsd-arm at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-arm
> To unsubscribe, send any mail to "freebsd-arm-unsubscribe at freebsd.org"

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/freebsd-arm/attachments/20140430/5c0afcf8/attachment.sig>