[PATCH] use vtophys instead of pmap_kextract

Olivier Houchard cognet at ci0.org
Wed Oct 31 10:26:01 UTC 2012


Hi Giovanni,

On Tue, Oct 30, 2012 at 11:12:20PM +0100, Giovanni Trematerra wrote:
> Hi,
> could you please review and commit the patch below?
> 
> The patch changes the calls to pmap_kextract in vtophys macro.
> This also fixes a compiler warning when SMP is enabled to Marvel
> ARMADA XP boards.
> 

I'm not sure there's a point in doing this, the uses of pmap_kextract() are
legit, and using vtophys() instead would just hide potential type bugs. I'd
rather just explicitely add a cast in the Marvel code, as your original patch
for the TI code did.

Regards,

Olivier


More information about the freebsd-arm mailing list