CFT/CFR: NUMA policy branch

Konstantin Belousov kostikbel at gmail.com
Tue Jul 7 09:38:01 UTC 2015


On Sun, Jul 05, 2015 at 07:06:27PM -0700, Adrian Chadd wrote:
> Hi,
> 
> I've done another update. kib@ has been beating me with the clue stick a bit.
> 
> https://github.com/freebsd/freebsd/compare/master...erikarn:local/adrian_numa_policy
> 
> * (kib) (numactl.c) fix up sorting of include files
> * (kib) (numactl.c) consistent use of values when calling err()
> * (kib) (numactl.c) consistently wrap lines at 78 characters, don't
> prematurely wrap lines
> * (kib) don't use the old-style BSD licence mentioning "regents", use
> the updated one
> * (kib) (vm_domain.c) don't break out after iterating a few times and
> have the API be unpredictable - so now the API will always succeed in
> reading a vm_policy
> 
> I've tested the policies (first-touch, fixed-domain, round-robin) and
> they all still work as advertised, both on threads and processes.
> 
> I'd appreciate more reviews and some further testing.

I did not found a fix for the wrong locking of seq_t.
Am I reading sys_numa_getaffinity() right that it does copyout() while
owning the process lock ?
The things are still syscalls instead of procctl() commands.

I did not read further, the patch is half-done at best.


More information about the freebsd-arch mailing list