chflags(2)'s flags argument.

[Pawel Jakub Dawidek]

On Mon, Mar 18, 2013 at 04:51:22PM +1100, Bruce Evans wrote:
> On Sun, 17 Mar 2013, Pawel Jakub Dawidek wrote:
> > Maybe we could arrange ports build with lchflags(2) changed to take
> > unsigned long to see how destructive the change really is, because my
> > expectation is that not very.
> 
> Why not use the correct type (u_int)?  u_long is just too long, since
> st_flags is only 32 bits, so much larger and realler API and ABI changes
> would be needed to support more than 32 flags.

I'd prefer leave u_long, as it breaks API as little as possible. This is
also the type that's being used by consumers of this API, as it was
documented in chflags(2) since forever. Also, as I already mentioned,
strtofflags(3) and fflagstostr(3) uses this type too.

> The garbage also has some style bugs.  It spells "unsigned long" as
> itself.  All other code in chflags.c still uses the normal abbreviation
> u_long.

Using u_long for chflags() prototypes in sys/stat.h will only work,
because of this:

#if !defined(_KERNEL) && __BSD_VISIBLE
/*
 * XXX We get miscellaneous namespace pollution with this.
 */
#include <sys/time.h>
#endif

As sys/time.h will include sys/types.h, eventhough sys/stat.h is trying
to avoid that at the begining.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20130318/4a97fdbe/attachment.sig>