Large Capsicum patch for review.

[Pawel Jakub Dawidek]

On Sun, Feb 24, 2013 at 07:05:57AM +0100, Christoph Mallon wrote:
> Hi.
> 
> On 23.02.2013 23:11, Pawel Jakub Dawidek wrote:
> > On Thu, Feb 14, 2013 at 12:02:22AM +0100, Pawel Jakub Dawidek wrote:
> >> I'd like to commit this patch:
> >>
> >> 	http://people.freebsd.org/~pjd/patches/capkern.diff
> > 
> > The patch was updated after the following changes and is available at
> > the link above:
> 
> I was not able to apply this patch cleanly and had to fudge with the diff:
> - Two diff headers (contrib/openbsm/etc/audit_event and lib/libc/gen/Makefile.inc) have an extra space after --- and +++, which is recognized as part of the filename.
>   Was this patch manually altered?

Nope, but I'm using some script to generate patch(1)-compatbile diff
from a perforce diff.

> - Two diffs (lib/libc/sys/cap_new.2 and sys/kern/uipc_mqueue.c) contain unexpanded $FreeBSD$ tags.
> I also had to guess, that the patch is to be applied onto r247201.
> I placed a cleaned up patch at http://tron.homeunix.org/zeug/FreeBSD/capsicum/0001-Capsicum-update.patch.
> 
> This is a really big patch bomb changing lots of unrelated things.
> Do you have smaller, more managable diffs for easier review?

I don't have smaller patch, unfortunately, but I don't think there are
unrelated things in there. Can you point me at them?

> I started reading the patch and found some minor glitches, e.g. mode in cap_sandboxed() should be u_int, not int.
> I will report more later.

I updated the patch. It is now against r247212.

Thanks!

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20130224/5819ca82/attachment.sig>