Print a (rate-limited) warning when UMA zone is full.
Pawel Jakub Dawidek
pjd at FreeBSD.org
Thu Nov 29 11:03:58 UTC 2012
On Thu, Nov 29, 2012 at 10:56:32AM +0000, Robert N. M. Watson wrote:
> On 29 Nov 2012, at 10:53, Pawel Jakub Dawidek wrote:
> > Agreed, especially if reaching those limits is expected by the
> > administrator and he is not going to increase them. But in this case it
> > would be even better to provide a way to turn them off.
>
> I wonder if each instance of a 'ratecheck' should come with an associated tunable/sysctl pair to allow suppression to be easily configured. I almost find myself wondering if we want something that looks a bit like our static SYSCTL/VFS_SET/etc declarations:
>
> static RATECHECK(..., "foo.bar.baz", ...);
>
> Unfortunately, the tunable/sysctl mismatch makes it slightly awkward since you'd need to declare both, but I think probably worthwhile.
I'm afraid you lost me here. Tunable/sysctl name is not related in any
way with the warning we are printing. How can you tell
kern.ipc.maxsockets affects limits of eight different UMA zones?
Also rate-limiting is not only used to print warnings, current
ppsratecheck() function just answer the question if the limit should be
enforced (something is happening too frequently) or not.
--
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20121129/ca492441/attachment.sig>
More information about the freebsd-arch
mailing list