[PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch

Kostik Belousov kostikbel at gmail.com
Tue Feb 16 19:54:47 UTC 2010


On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote:
> The following patch:
> http://www.freebsd.org/~attilio/x86.diff
> 
> starts the effort for having a shared sub-tree between amd64 and ia32.
> In this initial pass I putted the low-hanging fruits (bios/cpufreq)
> and what my customer was more interested in (isa/*) in order to
> kick-off the effort and, in the future, move gradually the code there.
> With the machine/isa/* cleanup about 10 files are trimmed and I'm sure
> more can be achieved easilly.
> There are few things to discuss. One, that I had not necessity to dig
> about still, is about how to organize headers (include/). Maybe some
> replication ala pc98 may be good.
> 
> The patch is big but it is mostly added and removed files (look at the
> files.X in order to understand better how files movements happened).
> 
> Hope to see comments and reviews.

IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv)
operation now, without a review, and post a diff that should be applied
to x86/ directory, as well as to build glue.

The small proposition I have is to #define read_eflags() read_rflags()
for amd64.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20100216/798596fb/attachment.pgp


More information about the freebsd-arch mailing list