[PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch

[Ed Maste]

On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote:

> The following patch:
> http://www.freebsd.org/~attilio/x86.diff
> 
> starts the effort for having a shared sub-tree between amd64 and ia32.
> In this initial pass I putted the low-hanging fruits (bios/cpufreq)
> and what my customer was more interested in (isa/*) in order to
> kick-off the effort and, in the future, move gradually the code there.
> With the machine/isa/* cleanup about 10 files are trimmed and I'm sure
> more can be achieved easilly.
> There are few things to discuss. One, that I had not necessity to dig
> about still, is about how to organize headers (include/). Maybe some
> replication ala pc98 may be good.
> 
> The patch is big but it is mostly added and removed files (look at the
> files.X in order to understand better how files movements happened).
> 
> Hope to see comments and reviews.
> 
> Attilio

As you'd expect I'd be very happy to see this cleanup go ahead; having
essentially the same file duplicated in two places just adds maintenance
burden.

Upon a quick review the patch looks OK to me.  I assume we'll "svn mv"
the i386 files into x86 and then add the amd64 diffs, thus maintaining
the history on the files in their new locations?

-Ed