Need a code review

M. Warner Losh imp at bsdimp.com
Wed Jul 30 18:43:21 UTC 2008


In message: <86r69buar0.fsf at ds4.des.no>
            Dag-Erling_Smørgrav <des at des.no> writes:
: "M. Warner Losh" <imp at bsdimp.com> writes:
: > http://people.freebsd.org/~gonzo/mips2/libpam.diff
: 
: This won't work.  Your patch unconditionally sets NO_STATIC_MODULES
: which will result in a non-functional libpam.a (the modules will be
: built into the library, but without any of the glue that allows the
: library to find them) not just on mips, but on all other platforms.

Thanks for the feedback.  We'll try to fix it.  Good catch.

Warner


More information about the freebsd-arch mailing list