[PATCH] Remove ENABLE_SSE option from i386 and pc98

Bruce Evans bde at zeta.org.au
Sat Jul 2 21:05:20 GMT 2005


On Sat, 2 Jul 2005, Ruslan Ermilov wrote:

> On Sat, Jul 02, 2005 at 01:41:15PM +0800, Xin LI wrote:
>> (re@ has been removed to reduce their mail load)
>>
>> Seems I need to have more sleep before sending patches...  Here it
>> is.
>>
> No, you want to unifdef(1) it in all sources, i.e.:
>
> /sys/conf/options.i386
> /sys/conf/options.pc98
> ...

unifdef(1) is even less suitable than usual for removing ifdefs.
Normally the main problem with unifdef(1) is that it mangles the
vertical whitespace, but for CPU_ENABLE_SSE the ifdefs are tangled so
they all need to be adjusted manually in a context-specific way, and
the correct untangling isn't clear.  The current condition for
configuring SSE is normally "#ifdef I686_CPU" after compile-time
untangling, but SSE doesn't really depend on 686'ness so the condition
shouldn't be written that way in the source code.

Bruce


More information about the freebsd-arch mailing list