BigDisk project: du(1) 64bit clean.

[Brooks Davis]

On Wed, Jan 05, 2005 at 11:20:56AM +0100, Pawel Jakub Dawidek wrote:
> On Tue, Jan 04, 2005 at 07:04:26PM -0800, Brooks Davis wrote:
> +> I'd be inclined to use the somewhat gross fix in PR 74567 in RELENG_5
> +> and do it right in HEAD. [...]
> 
> It allocates memory and we don't need it.
> Proposed fix is actually for RELENG_5. We can also do some magic inside
> du(1) to split 64bit value between two fields (fts_number/fts_pointer)
> when needed (on 32bit archs), but it would be really hackish.

I missed the fact this this was for RELENG_5 only, this seems like a
good solution there.

> +> [...] bde suggested changing fts_num to intmax_t.
> 
> The only issue here is that we break ABI if intmax_t will be bumped to
> 128bits in gcc, but we probably will have much bigger problems then:)
> I like this idea.

We'd have to bump nearly all library revs if we changed the the size of
intmax_t since we'd break printing of 64-bit numbers. :-)

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20050105/b4cc21b7/attachment.bin