scheduler (sched_4bsd) questions

[Stephan Uphoff]

On Tue, 2004-10-05 at 14:32, Julian Elischer wrote:
> -- snip --
> there are two things to notice..
> firstly the "corrected slot count (2->1)" messge is still there. (grumble).
> 
> this is hapenning when a threade dprocess moves back to be ing an 
> unthreaded preocess.
> for some reason, the number of openning s is not being set back to 1 but 
> rather to 2.
> I believe it is because while in thhe threaded mode it is already too 
> high by some amount
> (sometimes equivalent to NTHREAD) but I can not see why.
> Hopefully it is not a fatal problem (as it would be if it were too LOW, 
> but I hope to figure it
> out soon (maybe another one for Stephan :-)
> -- snip --

There is an extra SLOT_RELEASE - sched_rem already released the slot.

RCS file: /cvsroot/src/sys/kern/kern_switch.c,v
retrieving revision 1.97
diff -u -r1.97 kern_switch.c
--- kern_switch.c       5 Oct 2004 22:03:10 -0000       1.97
+++ kern_switch.c       9 Oct 2004 20:18:53 -0000
@@ -372,7 +372,6 @@
                sched_rem(tda);
                tda = kg->kg_last_assigned =
                    TAILQ_PREV(tda, threadqueue, td_runq);
-               SLOT_RELEASE(kg);
        }
 
        /*