option directive and turning on AOE

[Brooks Davis]

On Tue, Aug 31, 2004 at 02:40:56PM -0600, Scott Long wrote:
> Brooks Davis wrote:
> 
> >On Tue, Aug 31, 2004 at 02:27:33PM -0600, Scott Long wrote:
> >
> >>Sam wrote:
> >>
> >>
> >>>I've added code to if_ethersubr.c:/ether_demux/
> >>>to queue up AoE frames as they appear.  I followed
> >>>suit with other protocols and included my addition
> >>>inside of an #ifdef AOE.  Where do I turn this on?
> >>>I thought perhaps just adding an 'option AOE' to
> >>>the config would do it, but it doesn't -- so clearly
> >>>I don't understand how the option directive works.
> >>>The config man page doesn't talk about option/device
> >>>directives ...
> >>>
> >>>I'm still looking, but a clue would be well received.
> >>
> >>Did you modify /sys/conf/options to tell it about your
> >>AOE option?  If so, then you should have specified the name
> >>of a header file that the option would be #define'd into.
> >>Include that header file in if_ethersubr.c and you should
> >>have no problems.
> >>
> >>Incidentally, this might be an area when netgraph would be
> >>useful.  Instead of having an AoE specific hook in the
> >>stack, you could have an AoE netgraph module that uses the
> >>existing netgraph hooks.  It's just an idea, though.
> >
> >
> >Another option might be a PFIL hook.  There isn't one there now, but I
> >think I've seen talk of adding one.  Actually, if we did that, we could
> >get most of the netgraph specific hooks out of the ethernet code.
> 
> Do the PFIL hooks exist in 4.x?  I know that he's trying to target
> his driver for that right now.  Netgraph exists in both, so using it
> would keep his code more portable.  Anyways, this isn't my area of
> expertise, so do whatever you find to be best.

No, it doesn't look like pfil hooks are in 4.x.  If we had a new service
that wanted to use them in there, we could probably MFC them without
converting existing services making it a fairly low-risk operation.
Using netgraph is probably the easiest solution though.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20040831/a57cda4b/attachment.bin