Leave acpi enabled in panic shutdown case?

Nate Lawson nate at root.org
Thu Aug 26 10:09:43 PDT 2004


It seems some people may get a 2nd panic when acpi is shutdown after a 
panic.  I think it makes sense not to do the normal shutdown path if 
panicing.  Is the correct way to check for this panicstr != NULL?

The attached patch avoids calling AcpiTerminate() for the panic case.

-Nate
-------------- next part --------------
Index: acpi.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/acpica/acpi.c,v
retrieving revision 1.189
diff -u -r1.189 acpi.c
--- acpi.c	23 Aug 2004 16:28:42 -0000	1.189
+++ acpi.c	26 Aug 2004 01:37:13 -0000
@@ -1365,7 +1365,7 @@
 	    DELAY(1000000);
 	    printf("ACPI power-off failed - timeout\n");
 	}
-    } else {
+    } else if (panicstr == NULL) {
 	printf("Shutting down ACPI\n");
 	AcpiTerminate();
     }


More information about the freebsd-arch mailing list