kobj multiple inheritance

Justin T. Gibbs gibbs at scsiguy.com
Mon Sep 22 12:46:59 PDT 2003


> I believe that I have the kobj multiple inheritance changes about ready
> for committing now. I have locked up the class handling in kobj and I've
> re-done the method dispatch so that it is MP-safe without needing locks
> (I would appreciate a close look at that part by another pair of eyes).

I've only just glanced at these patches, but I don't see how the
method cache is now MP safe.  Aren't you still vulnerable to a cache
collision from two different threads performing an operation on the
same class?

I still believe that the concept of inherited interfaces is better
way to achieve multiple inheritance.  The methods I may want to
inherit need not be associated with what we currently call a device
class.  The nice thing about your approach is that it doesn't require
a massive rototilling of the drivers, but I fear it doesn't go far
enough toward providing flexible inheritence.

--
Justin



More information about the freebsd-arch mailing list