Message buffer and printf reentrancy patch
Marcel Moolenaar
marcel at dhcp01.pn.xcllnt.net
Sun Jun 15 11:08:20 PDT 2003
On Sun, Jun 15, 2003 at 02:06:50PM +0100, Ian Dowse wrote:
>
> Index: sys/sys/msgbuf.h
> ===================================================================
> RCS file: /dump/FreeBSD-CVS/src/sys/sys/msgbuf.h,v
> retrieving revision 1.20
> diff -u -r1.20 msgbuf.h
> --- sys/sys/msgbuf.h 28 Mar 2003 02:50:10 -0000 1.20
> +++ sys/sys/msgbuf.h 15 Jun 2003 12:00:45 -0000
> @@ -41,16 +41,32 @@
> #define MSG_MAGIC 0x063062
> u_int msg_magic;
> int msg_size; /* size of buffer area */
> - int msg_bufx; /* write pointer */
> - int msg_bufr; /* read pointer */
> + int msg_wseq; /* write sequence number */
> + int msg_rseq; /* read sequence number */
> + int msg_seqmod; /* range for sequence numbers */
> char *msg_ptr; /* pointer to buffer */
> u_int msg_cksum; /* checksum of contents */
> };
Nit: please move the msg_ptr field before the int fields. There used
to be no internal padding, but on 64-bit platforms with an odd number
of ints, this will be the case.
--
Marcel Moolenaar USPA: A-39004 marcel at xcllnt.net
More information about the freebsd-arch
mailing list