cvs commit: src/sys/dev/fxp if_fxp.c

[M. Warner Losh]

[[ moved to arch ]]

In message: <20030415104824.H99028 at sasami.jurai.net>
            "Matthew N. Dodd" <mdodd at FreeBSD.ORG> writes:
: On Tue, 15 Apr 2003, M. Warner Losh wrote:
: > How do you tell if a BAR is enabled?  I assume you mean 'check to see
: > if the BAR has an allocated resource' here?  In that case, my XXX
: > applies :-(  We should allocate a resonable resource.
: 
: Actually I misspoke; we should modify pci_enable_io_method() so that we
: can indicate a failure to enable the requested space.

foo |= BIT;
if ((foo & BIT) == 0)
   whine-and-fail;

is that what you are saying?

: This would keep drivers from having to check and see if PCIM_CMD_PORTEN or
: PCIM_CMD_MEMEN is set.

Yes.

: This requires changing the definition of the 'enable_io' method.
:
: Since we're here we should change 'disable_io' and
: '{enable,disable}_busmaster' as well.

If we're going to do this, then we need to do it soon.

Warner