Review Uses/apache.mk

[bernard]

On 18.09.2017 21:16, olli hauer wrote:
> Hi Bernard,
> 
> sorry for the long delay.
> 
> I've tried to see your review patch in a small test build but was not
> able to apply the raw patch that can be downloaded on the review page.
> 
> In the arc help or on the wiki I see no hint how to checkout the full
> changed files for a review, is this even possible?
> (I suspect I'm getting to old for such tools ...)
> 
> Anyway I have some additional patch sleeping since a long time on my
> private repo, the intention is to move the module include line from
> httpd.conf to a dedicated file under modules.d.
> (Perhaps APID should be renamed to MODID or something else)
> https://people.freebsd.org/~ohauer/diffs/Mk__apache.mk-modules-201708.diff
> 
> Perhaps this patch can solve the issue for users during update or
> reinstalling a module where the line load is missing after reinstall
> (pkg bug) or commented after upgrade.
> 
> Additional I've read today an article about an apache issue (sorry
> only in german)
> https://www.golem.de/news/optionsbleed-apache-webserver-blutet-1709-130105.html
> 
> and have shaped already the apache patch from the upstream repo.
> https://people.freebsd.org/~ohauer/diffs/apache24_options_20170918.diff
> 
> PS:
> would you mind to join the apache@ team, seems you are a very good 
> candidate.
> In case of yes pleas add your @FreeBSD nic to the wiki page
> https://wiki.freebsd.org/Apache

Hi Olli,

Added myself to the wiki page as part of apache at . Is there anything else 
that needs to be arranged? Mail postmaster@ for inclusion of brnrd@ into 
apache@ ?

I'll make the full file and the patches available on my Github and 
website. If you have php-arcanist installed, it should be as simple as 
`arc patch D12308` but I've not tried that...

The patches seem worth while. The diff is becoming a bit too big I'm 
afraid. I've got another revision almost done, will get it to you all.
In my private github: 
https://github.com/Sp1l/ports/commit/a6fc987f3016ca594c3b9930615e2ea4b86a6b43
As svn diff https://brnrd.eu/bsd/patch-Mk_Uses_apache.mk
There's a build of all ports depending on Apache in progress on 
https://keg.brnrd.eu/build.html?mastername=111amd64-default&build=2017-10-07_21h38m23s

The options patch apache24_options_20170918.diff was already committed I 
believe? Meanwhile I have a patch for 2.4.28 in bugzilla for review as 
well: https://bugs.freebsd.org/222814. The 2.4.28 buildlog is on 
https://keg.brnrd.eu/data/111amd64-default/2017-10-07_21h38m23s/logs/apache24-2.4.28.log

Cheers,

Bernard.