apache 2.2 ports

[Adam Weinberger]

On 7 Sep, 2014, at 11:14, olli hauer <ohauer at gmx.de> wrote:

> On 2014-09-07 16:59, Adam Weinberger wrote:
>> On 7 Sep, 2014, at 6:31, olli hauer <ohauer at gmx.de> wrote:
>> 
>>> On 2014-09-06 17:24, Adam Weinberger wrote:
>>>> apache team -
>>>> 
>>>> So it seems that setting USE_APACHE=22 doesn’t actually depend on apache-2.2. This means that every USE_APACHE=22 port is broken, and as of right now won’t have any 10.1 packages.
>>>> 
>>>> I’m happy to go through and add "DEFAULT_VERSIONS= APACHE=22” to this ports, but I wanted to check with you guys first. Is that the right way to fix it? Is there something else that can be done to make USE_APACHE=22 actually depend on apache-2.2?
>>>> 
>>> 
>>> Hi Adam,
>>> 
>>> could you give the patch below a try?
>>> I've tested the patch with a small selection from USE_APACHE=(22|22+|24) ports and with the patch bsd.default-versions.mk does not overwrite the requirements.
>> 
>> That patch works perfectly for me. USE_APACHE=22, 22+, and 24 all do the right thing now.
>> 
>> However, it doesn’t check against bad values. USE_APACHE=42 just drops the apache dependency altogether... most other USE_* systems put out an error in that situation.
>> 
>> # Adam
> 
> 
> Hi Adam,
> 
> are you sure about bad values?
> 
> Tested only with simple ports
> 
> $ cd www/mod_log_sql2
> $ sed -i.bak 's/22/42/' Makefile
> $ make
> ===>  mod_log_sql-1.101_6 : Error from bsd.apache.mk. Illegal use of USE_APACHE ( 42+ ).
> *** Error code 1
> 
> $ cd www/blogsum
> $ sed -i.bak 's/22/32/' Makefile
> $ make
> ===>  blogsum-1.1_2 is marked as broken: : Error from bsd.apache.mk. apache24 is installed (or APACHE_PORT is defined) and port requires apache32 at least.
> *** Error code 1
> 
> 
> I have to admit bsd.apache.mk is not optimal, needs a major rewrite and split into separate server / modules files.
> For server bsd.apache.mk is OK but modules and other stuff should go into a Uses/apache.mk file.

Haha actually I tested it with USE_APACHE=32... I had no idea that was a valid value.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org