please test qemu port update

[Juergen Lock]

On Fri, Apr 29, 2005 at 03:13:15AM -0400, Jung-uk Kim wrote:
> On Thursday 28 April 2005 03:14 pm, Jung-uk Kim wrote:
> > On Thursday 28 April 2005 03:02 pm, Juergen Lock wrote:
>[...]

> > > Or is this a difference between i386 and amd64?
> >
> > I believe Makefile.target is doing something wrong but I haven't
> > found it yet.  I believe the culprit is Makefile.target not
> > checking ARCH == amd64 but x86_64.  In fact, it works perfect for
> > i386.
> 
> Yup, that's it.  MAKE_ENV was overriding ARCH==x86_64 in QEMU's 
> makefiles.
> 
Yeah looks like after .if !defined(NOPRECIOUSMAKEVARS) in
/usr/ports/Mk/bsd.port.mk...

> > > And if it really is, I would prefer setting the right variables
> > > (like USE_GMAKE, see /usr/ports/Mk/bsd.port.mk) instead of simply
> > > overriding the do-* targets.
> >
> > I'd love to find it out.  I will let you know when I get that
> > right.
> 
> The final patch (I hope) is attached.  This version includes few minor 
> fixes too.
> 
> I think it is commitable now.

 I found one small bug,

Index: Makefile
@@ -39,6 +39,8 @@
 BUILD_DEPENDS+=	gcc34:${PORTSDIR}/lang/gcc34
 GCCVERSION=	030402
 CC=		gcc34
+.else
+USE_GCC=	3.4
 .endif
 .else
 USE_GCC=	3.4

(tho it probably doesnt matter as i doubt there's an amd64 branch
that uses an older gcc than 3.4...)

 Any commiters here, or should i still send-pr?

	Juergen