amd64/67712: Extra informal text when trying to dump but dumpdev is not set.

[Willem Jan Withagen]

>Number:         67712
>Category:       amd64
>Synopsis:       Extra informal text when trying to dump but dumpdev is not set.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-amd64
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 08 13:10:17 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Willem Jan Withagen
>Release:        5.2-CURRENT
>Organization:
Digiware
>Environment:
FreeBSD opteron.digiware.nl 5.2-CURRENT FreeBSD 5.2-CURRENT #22: Tue Jun  8 13:44:17 CEST 2004     wjw at opteron.digiware.nl:/usr/obj/home2/src/sys/OPTERON.amd64  amd64
      
>Description:
Calling doadump without dumpdev set claims that the partition was too small. Well it worse, it did not exist.
This patch gives a better diagnostic.
It might also be usefull with i386 ea.      
>How-To-Repeat:
      
>Fix:
--- sys/amd64/amd64/dump_machdep.c.org  Tue Jun  8 14:56:49 2004
+++ sys/amd64/amd64/dump_machdep.c      Tue Jun  8 14:56:00 2004
@@ -85,6 +85,8 @@
        if (di->mediasize <
            Maxmem * (off_t)PAGE_SIZE + sizeof kdh * 2 + 64*1024) {
                printf("\nDump failed. Partition too small.\n");
+               if (di->mediasize == 0 )
+                   printf("Partition to dump on is not set. See dumpon(8)\n");
                return;
        }
        dumplo = di->mediaoffset + di->mediasize - Maxmem * (off_t)PAGE_SIZE;
      
>Release-Note:
>Audit-Trail:
>Unformatted: