msdosfs patch

Greg J. xcas at cox.net
Sat Jan 31 21:13:23 PST 2004


John-Mark Gurney wrote:
> Greg J. wrote this message on Sat, Jan 31, 2004 at 12:31 -0700:
> 
>>>Since Tim didn't mail his patch to the amd64 list, perhaps you could 
>>>re-post it there?
>>
>>oops.. I thought Tim's patch went to the freebsd-amd64 list as well.. 
>>sorry. It's attached to this email. :)
> 
> 
> looks good, though was this (mis)spelling of size_t intentional?
> 
> [...]
> 
>> static u_int16_t unix2doschr(const u_char **, size_t *, struct msdosfsmount *);
> 
> [...]
> 
>>-	int i, j, l;
>>+	ssize_t i, j;
>>+	int l;
>> 	int conv = 1;
>> 	const u_char *cp, *dp, *dp1;
>> 	u_char gentext[6], *wcp;
>>@@ -531,7 +532,7 @@
>> 	 * Filenames with some characters are not allowed!
>> 	 */
>> 	for (cp = un, i = unlen; i > 0;)
>>-		if (unix2doschr(&cp, (size_t *)&i, pmp) == 0)
>>+		if (unix2doschr(&cp, &i, pmp) == 0)
>> 			return 0;
>> 
>> 	/*
> 
> 
I'm no C expert.. but I'm guessin that (ssize_t) is a typo.. funny how 
it still works?


More information about the freebsd-amd64 mailing list