amd64/74669: The port math/octave is marked BROKEN on amd64

[Roland Smith]

On Sat, Dec 04, 2004 at 08:27:28AM -0600, Conrad J. Sabatier wrote:
>
> A better fix would be to determine exactly where -fPIC is needed and
> apply patches where appropriate, but this is fine for a "quick fix".

Ok, I've looked into it, and the problem seems to be in the libglob that
is included in octave. When libglob.a is linked into liboctave.so, the
linking fails because libglob isn't compiled with -fPIC. Included is a
new patch for blob's Makefile.in, which should go in files. Also
included is a new patch for the ports Makefile, removing the BROKEN
state for octave.

Unfortunately I can only test this myself on amd64. Could someone
confirm that this doesn't hurt on other platforms, especially i386?

Roland
-- 
R.F. Smith                           /"\    ASCII Ribbon Campaign
r s m i t h @ x s 4 a l l . n l      \ /    No HTML/RTF in email
http://www.xs4all.nl/~rsmith/         X     No Word docs in email
                                     / \    Respect for open standards
-------------- next part --------------
--- glob/Makefile.in.orig	Sat Dec  4 16:59:54 2004
+++ glob/Makefile.in	Sat Dec  4 17:00:04 2004
@@ -25,7 +25,7 @@
 
 CC = @CC@
 CPPFLAGS = @CPPFLAGS@
-CFLAGS = @CFLAGS@
+CFLAGS = @CFLAGS@ -fPIC
 
 # Information determined by configure.
 DEFS = @DEFS@
-------------- next part --------------
--- Makefile.orig	Fri Dec  3 20:36:40 2004
+++ Makefile	Sat Dec  4 16:57:35 2004
@@ -23,10 +23,6 @@
 
 .include <bsd.port.pre.mk>
 
-.if ${ARCH} == "amd64"
-BROKEN=		"Does not build on amd64 (Shared libraries must be compiled with -fPIC)"
-.endif
-
 .if ${PORTOBJFORMAT} == "elf"
 GNU_HOST=	${ARCH}-portbld-freebsd${OSREL}
 .else
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-amd64/attachments/20041204/55339f85/attachment.bin