[FEEDBACK REQUIRED] patch for ipfw/ipfw2 on alpha/sparc64

[Luigi Rizzo]

On Sat, May 24, 2003 at 04:44:15PM -0400, John Baldwin wrote:
...
> >> +#ifdef I386
> >>      fs = ((ipfw_insn_pipe *)cmd)->pipe_ptr;
> >> +#else
> >> +    bcopy(& ((ipfw_insn_pipe *)cmd)->pipe_ptr, &fs, sizeof(fs));
> >> +#endif
> >>  
> > 
> > This is not a 'reviewed-by:', but these should be #ifdef __i386__
> > rather than #ifdef I386.
> 
> Why is the #ifdef even there?  Why not use bcopy all the time?

performance maybe ? This particular one is called everytime
you deliver a packet to a dummynet pipe.

	cheers
	luigi

> -- 
> 
> John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
> "Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/